Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specs to (goes) option #841

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Update specs to (goes) option #841

merged 4 commits into from
Dec 9, 2024

Conversation

yevhenii-nadtochii
Copy link
Contributor

@yevhenii-nadtochii yevhenii-nadtochii commented Dec 9, 2024

This PR updates specs to (goes) option.

In particular, it specifies the supported field types and replaces %s-based error message pattern for named placeholders, just as in IfSetAgain option.

@yevhenii-nadtochii yevhenii-nadtochii self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (0be904f) to head (0ea15a2).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #841   +/-   ##
=========================================
  Coverage     75.16%   75.16%           
  Complexity     1178     1178           
=========================================
  Files           190      190           
  Lines          4293     4293           
  Branches        346      346           
=========================================
  Hits           3227     3227           
  Misses          935      935           
  Partials        131      131           

@yevhenii-nadtochii yevhenii-nadtochii marked this pull request as ready for review December 9, 2024 14:51
@yevhenii-nadtochii
Copy link
Contributor Author

@armiol @alexander-yevsyukov PTAL

@yevhenii-nadtochii yevhenii-nadtochii merged commit 57c83eb into master Dec 9, 2024
7 checks passed
@yevhenii-nadtochii yevhenii-nadtochii deleted the specs-for-goes branch December 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants