Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for error propagation #1113

Merged
merged 31 commits into from
Jul 15, 2019
Merged

Tests for error propagation #1113

merged 31 commits into from
Jul 15, 2019

Conversation

dmdashenkov
Copy link
Contributor

@dmdashenkov dmdashenkov commented Jul 15, 2019

This PR adds some missing for the codebase of #1104 and removes dead code.

@dmdashenkov dmdashenkov self-assigned this Jul 15, 2019
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #1113 into master will increase coverage by 1.57%.
The diff coverage is 89.09%.

@@             Coverage Diff              @@
##             master    #1113      +/-   ##
============================================
+ Coverage     90.87%   92.45%   +1.57%     
- Complexity     3935     3947      +12     
============================================
  Files           540      526      -14     
  Lines         12882    12690     -192     
  Branches        722      721       -1     
============================================
+ Hits          11707    11733      +26     
+ Misses          952      740     -212     
+ Partials        223      217       -6

@dmdashenkov dmdashenkov requested a review from armiol July 15, 2019 12:38
@dmdashenkov
Copy link
Contributor Author

@armiol, PTAL.

@dmdashenkov dmdashenkov merged commit 34266f4 into master Jul 15, 2019
@dmdashenkov dmdashenkov deleted the tests-for-error-propagation branch July 15, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants