Allow optional command generation on event #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
============================================
- Coverage 92.45% 92.44% -0.02%
- Complexity 3947 3951 +4
============================================
Files 526 526
Lines 12690 12694 +4
Branches 721 721
============================================
+ Hits 11733 11735 +2
- Misses 740 743 +3
+ Partials 217 216 -1 |
armiol
approved these changes
Jul 15, 2019
dmdashenkov
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
@alexander-yevsyukov, LGTM.
However, please mention the reasoning behind marking AggregatePart as @Expperimental.
…er-on-event Conflicts: server/src/main/java/io/spine/server/command/model/CommandHandlerMethod.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to have
@Commandmethods that accept an event to ignore it returningOptional.empty()orEitherwithNothing.AggregateRoot,AggregatePartand corresponding repositories were marked@Experimentalto reflect the fact that this API has not been proved to be in real projects.