-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import third-party events #1152
Changes from 42 commits
ac42ada
f4772e8
843424b
d4a368d
0de37a8
d1cf0d6
94f5874
4e4805b
c84972b
83e2d39
8e159d3
9c25007
7c34cb9
35701ee
e97c8d1
83a9195
5a0a67a
c2fea8f
39fa1ab
5ef8dc4
8bec505
7b1c966
2cecbf7
7386d35
be3b949
3da6d17
67ed608
405f676
d8e7007
aa0f693
1ea31f1
9bd7599
8894d6c
bf08008
48766d7
d92a6b8
b340993
8288e6c
0e26690
708dc0b
9bdc2ba
b39f53b
5da84f0
0fc181b
922e81e
0c93249
32f37a6
aaae84e
300197b
cb400a3
e0f85cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,4 +60,3 @@ | |
*/ | ||
boolean allowImport() default false; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,7 +75,7 @@ final class ConfigurationChangeObserver extends AbstractChannelObserver implemen | |
* types. | ||
* | ||
* <p>If the request originates from a previously unknown Bounded Context, | ||
* {@linkplain IntegrationBus#notifyOfCurrentNeeds() publishes} the needs of current context, | ||
* {@linkplain IntegrationBus#introduceSelf() publishes} the needs of current context, | ||
* since they may be unknown to the new context. | ||
* | ||
* @param value {@link RequestForExternalMessages} form another Bounded Context | ||
|
@@ -89,7 +89,7 @@ public void handle(ExternalMessage value) { | |
clearStaleSubscriptions(request.getRequestedMessageTypeList(), origin); | ||
if (!knownContexts.contains(origin)) { | ||
knownContexts.add(origin); | ||
integrationBus.notifyOfCurrentNeeds(); | ||
integrationBus.introduceSelf(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't sound right. The bus is already introduced to the system. It's the new context which introduces itself. Or, if you want the bus to do the job the method should be named differently. |
||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we hide this class back?