Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty context #1185

Merged
merged 13 commits into from
Oct 31, 2019
Merged

Empty context #1185

merged 13 commits into from
Oct 31, 2019

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Oct 30, 2019

This PR adds EmptyContext type for complementing message types that do not have a context (such as entity state) where bi-consuming APIs require both message and its context.

Version updates:

  • spine-base -> 1.1.9
  • Gradle -> 5.6.3

The version advanced to 1.1.12.

This reverts commit 11eaf05
@alexander-yevsyukov alexander-yevsyukov self-assigned this Oct 30, 2019
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #1185 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1185      +/-   ##
============================================
+ Coverage     91.35%   91.38%   +0.02%     
- Complexity     4260     4261       +1     
============================================
  Files           550      550              
  Lines         13343    13343              
  Branches        786      786              
============================================
+ Hits          12190    12193       +3     
+ Misses          909      908       -1     
+ Partials        244      242       -2

Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov LGTM with a comment.

core/src/main/proto/spine/core/empty_context.proto Outdated Show resolved Hide resolved
@alexander-yevsyukov alexander-yevsyukov merged commit f550140 into master Oct 31, 2019
@alexander-yevsyukov alexander-yevsyukov deleted the empty-context branch October 31, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants