Allow Version in ordering filters
#1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in `AbstractColumnMapping`.
Renamed `Signal.typeUrl()` -> `Signal.enclosedTypeUrl()` to avoid clash with the `KnownMessage.typeUrl()`.
dmitrykuzmin
changed the title
Version in ordering filtersVersion in ordering filters
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
============================================
+ Coverage 91.38% 91.41% +0.03%
- Complexity 4232 4235 +3
============================================
Files 547 547
Lines 13189 13190 +1
Branches 749 750 +1
============================================
+ Hits 12053 12058 +5
+ Misses 898 896 -2
+ Partials 238 236 -2 |
|
@armiol PTAL. |
…into version-in-ordering-filters � Conflicts: � license-report.md
armiol
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
@dmitrykuzmin LGTM, but please be careful with the versioning. Make sure it's going to be an increment.
…into version-in-ordering-filters � Conflicts: � license-report.md � pom.xml � server/src/main/java/io/spine/system/server/TraceEventObserver.java � version.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
io.spine.core.Versionto the types that can be used in the ordering filters ("greater than", "less than or equals", etc.).It is reasonable because in most storages, including our own ones, the
Versioninstances are mapped to values which can be reasonably ordered.Spine version advances to
1.2.4.