Allow subscribing on same rejection with different causes #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
============================================
+ Coverage 91.49% 91.53% +0.03%
- Complexity 4269 4278 +9
============================================
Files 547 549 +2
Lines 13346 13355 +9
Branches 759 759
============================================
+ Hits 12211 12224 +13
+ Misses 894 892 -2
+ Partials 241 239 -2 |
The getDeclaredMethods may behave differently in IDE and during the Gradle build process.
|
@armiol PTAL. |
armiol
requested changes
Nov 28, 2019
server/src/main/java/io/spine/server/event/model/RejectionDispatchKey.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/event/model/RejectionDispatchKey.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/event/model/SubscriberMethod.java
Outdated
Show resolved
Hide resolved
server/src/test/java/io/spine/server/event/model/RejectionDispatchKeyTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/io/spine/server/event/model/RejectionDispatchKeyTest.java
Outdated
Show resolved
Hide resolved
alexander-yevsyukov
requested changes
Nov 28, 2019
server/src/main/java/io/spine/server/event/model/EventSubscriberMethod.java
Outdated
Show resolved
Hide resolved
armiol
reviewed
Nov 29, 2019
|
|
||
| @Override | ||
| public DispatchKey key() { | ||
| if (parameterSpec().acceptsCommand()) { |
There was a problem hiding this comment.
Let's discuss this one in person. I am not sure I understand.
alexander-yevsyukov
previously requested changes
Nov 29, 2019
server/src/main/java/io/spine/server/event/model/RejectionDispatchKeys.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/event/model/RejectionDispatchKeys.java
Outdated
Show resolved
Hide resolved
# Conflicts: # license-report.md
…atchKeys.java Co-Authored-By: Alexander Yevsyukov <alexander.yevsyukov@teamdev.com>
armiol
requested changes
Dec 3, 2019
| Class<? extends CommandMessage> commandMessageClass = toCommandMessage(parameters[1]); | ||
| Class<?> secondParameter = parameters[1]; | ||
| checkArgument(CommandMessage.class.isAssignableFrom(secondParameter), | ||
| "The method `%s` should have the second parameter assignable from CommandMessage, but has `%s`.", |
| import io.spine.type.MessageClass; | ||
|
|
||
| /** | ||
| * A handler method that handles rejections. |
There was a problem hiding this comment.
that is capable of handling rejection messages.
It's not that it always handles those. It just may handle.
| /** | ||
| * {@inheritDoc} | ||
| * | ||
| * <p>If a handler method spec is for a rejection — creates rejection dispatch key. |
There was a problem hiding this comment.
In case this method is declared to handle a rejection, a rejection-specific dispatch key is created.
| * <p>If a handler method spec is for a rejection — creates rejection dispatch key. | ||
| */ | ||
| @Override | ||
| default DispatchKey key() { |
There was a problem hiding this comment.
I also think, @OverridingMethodsMustInvokeSuper.
| @@ -139,6 +139,9 @@ default void ensureExternalMatch(boolean expectedValue) throws SignalOriginMisma | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Creates a handler method dispatch key out of the {@code message class}. | |||
There was a problem hiding this comment.
...out of the {@linkplain #messageClass() message class}.
|
@armiol PTAL again. |
…this specific interface
# Conflicts: # license-report.md
armiol
approved these changes
Dec 4, 2019
yuri-sergiichuk
dismissed
alexander-yevsyukov’s stale review
Alex already approved the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1202.
The
EventHandlerMethodnow shares theDispatchKeylogic with theEventSubscriberMethodand creates aDispatchKeyfor rejections in the very same way.