Extend Filters API with strongly-typed columns support
#1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into extend-filters-api
...to avoid extra object creation.
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
============================================
- Coverage 91.14% 90.97% -0.17%
- Complexity 4807 4829 +22
============================================
Files 631 631
Lines 15069 15129 +60
Branches 846 846
============================================
+ Hits 13734 13764 +30
- Misses 1070 1102 +32
+ Partials 265 263 -2 |
|
@armiol, @yuri-sergiichuk PTAL. |
armiol
approved these changes
Mar 5, 2020
|
@dmitrykuzmin please make sure you don't submit the same version as @dmdashenkov in #1245. |
…into extend-filters-api � Conflicts: � license-report.md � pom.xml � version.gradle
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1244.
The
Filtersutility is extended with methods that allow to createFilterinstances from strongly-typed columns and fields.This should be convenient for users that do not rely on high-level
ClientAPI and use plainQueryService,SubscriptionService, etc. instead.Spine version advances to
1.4.13.