-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post and forget #1292
Merged
Merged
Post and forget #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
============================================
- Coverage 91.06% 91.04% -0.02%
- Complexity 4708 4712 +4
============================================
Files 606 606
Lines 14992 15005 +13
Branches 851 853 +2
============================================
+ Hits 13652 13662 +10
- Misses 1072 1077 +5
+ Partials 268 266 -2 |
yuri-sergiichuk
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-yevsyukov LGTM.
Please consider the minor suggestions below.
... to avoid warnings at the calling sites.
Co-authored-by: Yuri Sergiichuk <23313616+yuri-sergiichuk@users.noreply.github.com>
Also: * Improve code layout
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ability to post a command without subscribing to events.
Prior to this PR, it was possible to call
CommandRequest.post()
ignoring the result of the method. Now the contract is tightened:post()
. Otherwise,IllegalStateException
will be thrown suggesting to callobserve()
orpostAndForget()
instead.postAndForget()
should be called. If this method is called and at least one event subscription were requested, the method throwsIllegalStateException
suggesting to callpost()
instead.post()
cannot be ignored.