Simplify unicast event routing #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
============================================
- Coverage 91.06% 91.05% -0.02%
- Complexity 4746 4750 +4
============================================
Files 608 609 +1
Lines 15090 15101 +11
Branches 854 854
============================================
+ Hits 13742 13750 +8
- Misses 1080 1082 +2
- Partials 268 269 +1 |
yuri-sergiichuk
approved these changes
Oct 24, 2020
armiol
approved these changes
Oct 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
unicast()methods forEventRoutingto simplify the cases when an event target is only one entity.Previously, it was required to wrap the ID of the target entity into
EventRoute.withId()utility call.Only some of the
withId()calls were replaced with simplified calls to make this PR merge sooner.We'll migrate to simpler API where appropriate when corresponding framework areas or tests are updated.