-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Enable IntegrationBroker
dispatch events regardless of registration order of subscribing and publishing BCs
#1402
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x-dev #1402 +/- ##
=============================================
- Coverage 91.05% 91.05% -0.01%
- Complexity 4789 4791 +2
=============================================
Files 614 614
Lines 15185 15201 +16
Branches 861 860 -1
=============================================
+ Hits 13827 13841 +14
- Misses 1085 1091 +6
+ Partials 273 269 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yevhenii-nadtochii please see my comments.
Also, next time please mark the PR as "Ready for review". It's in its "Draft" state at the moment.
server/src/main/java/io/spine/server/integration/IntegrationBroker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/integration/IntegrationBroker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/integration/IntegrationBroker.java
Outdated
Show resolved
Hide resolved
server/src/test/proto/spine/test/integration/broker/events.proto
Outdated
Show resolved
Hide resolved
server/src/test/proto/spine/test/integration/broker/events.proto
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/integration/ExternalNeedsObserver.java
Show resolved
Hide resolved
@yevhenii-nadtochii one more thing. We'll need to bump the library version. I'll show you how to do that. |
IntegrationBroker
dispatch events regardless of registration order of subscribing and publishing BCs
Now,
IntegrationBroker
sends out anExternalMessagesSourceAvailable
notification as it registered with aBoundedContext
in order to notify other brokers that a new potential contributor is available. Other brokers react on this notification by re-stating their needs of external events by sending aRequestForExternalMessages
.Notes
IntegrationBroker
tests were re-written withBlackBoxContext
;IntegrationBroker
. Instead of checking forUnsupportedExternalMessage
as it stated in the title, it was checking forUNSUPPORTED_EVENT_VALUE
that is a responsibility ofEventBus
.Non-related changes
BoundedContext.InternalAccess.register*()
methods chainable;EmptyAggregate
inserver/src/test/proto/spine/test/shared_types.proto
had incorrect entity type;BlackBoxContext
implementCloseable
.