Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop treating received events as emitted in BlackBoxBoundedContext #904

Merged
merged 8 commits into from
Dec 5, 2018

Conversation

mdrachuk
Copy link
Contributor

@mdrachuk mdrachuk commented Dec 5, 2018

This PR filters out the events sent by BlackBoxBoundedContext from emitted events verifiers.

Such a change is required to match the expected behaviour when calling methods treating emitted events.

@mdrachuk mdrachuk added the bug label Dec 5, 2018
@mdrachuk mdrachuk self-assigned this Dec 5, 2018
@mdrachuk mdrachuk requested a review from armiol December 5, 2018 19:51
@mdrachuk
Copy link
Contributor Author

mdrachuk commented Dec 5, 2018

@armiol, PTAL.

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #904 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #904      +/-   ##
===========================================
- Coverage      93.2%   93.2%   -0.01%     
+ Complexity     3822    3821       -1     
===========================================
  Files           522     522              
  Lines         12585   12591       +6     
  Branches        710     710              
===========================================
+ Hits          11730   11735       +5     
+ Misses          627     626       -1     
- Partials        228     230       +2

Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdrachuk LGTM.

@mdrachuk mdrachuk merged commit 3d99f6f into master Dec 5, 2018
@mdrachuk mdrachuk deleted the black-box-check-emitted-events-only branch December 5, 2018 20:34
@armiol armiol mentioned this pull request Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants