Calculate zoneOffset based on zoneId in TestActorRequestFactory
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
============================================
+ Coverage 93.38% 93.38% +<.01%
- Complexity 3868 3869 +1
============================================
Files 529 529
Lines 12629 12637 +8
Branches 703 703
============================================
+ Hits 11793 11801 +8
Misses 607 607
Partials 229 229 |
|
@dmdashenkov, PTAL. |
dmdashenkov
approved these changes
Dec 13, 2018
| @@ -98,6 +100,19 @@ public static TestActorRequestFactory newInstance(Class<?> testClass, TenantId t | |||
| ZoneIds.systemDefault()); | |||
| } | |||
|
|
|||
| private static ZoneOffset idToZoneOffset(ZoneId zoneId) { | |||
| String id = zoneId.getValue(); | |||
| java.time.ZoneId javaZoneId = java.time.ZoneId.of(id); | |||
There was a problem hiding this comment.
Please inline the zoneId.getValue() call. The id variable doesn't make the code more readable, since "ID" is too broad of a term.
…nto calculate-zone-offset-from-id
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #885.
Before, to create an instance of
TestActorRequestFactory, two timezone-related parameters were needed:zone ID and zone offset.
Since it is possible to calculate offset based on ID, two parameters have been substituted with a single one - zone ID. Zone offset is now calculated based on the ID.