Remove Sharding
#929
Merged
Remove Sharding
#929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to set `TransportFactory` instead of `IntegrationBus` for the `BoundedContextBuilder`. Wire all instances of `BlackBoxBoundedContext` to the same transport in order to allow them to communicate via external events.
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
============================================
- Coverage 93.37% 93.02% -0.35%
+ Complexity 3864 3712 -152
============================================
Files 529 508 -21
Lines 12651 12135 -516
Branches 705 675 -30
============================================
- Hits 11813 11289 -524
- Misses 608 623 +15
+ Partials 230 223 -7 |
dmdashenkov
approved these changes
Dec 26, 2018
| @DisplayName("TransportFactory if it was set") | ||
| void transportFactory() { | ||
| @SuppressWarnings("unchecked") // OK for this mock. | ||
| TransportFactory factory = InMemoryTransportFactory.newInstance(); |
There was a problem hiding this comment.
Please fix the alignment.
| private final BoundedContext boundedContext; | ||
| private final CommandMemoizingTap commandTap; | ||
| private final MemoizingObserver<Ack> observer; | ||
|
|
||
|
|
There was a problem hiding this comment.
This line is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a scope of planned
Inboxfeature, the sharding-based approach used up until now becomes obsolete. This PR removes the existing implementation ofShardingand allows to run tests withoutShardingResetJUnit extension.Other API changes:
TransportFactoryfor theBoundedContextBuilder, not theIntegrationBus— to make the transport configuration consistent across multiple bounded contexts.BlackBoxBoundedContextto the same transport to enable a communication via external events.Minor changes:
@authortags removed in the updated files.VisibilityGuardTestEnvcleared from the unused code.BlackBoxBoundedContextnow relies on Java 8 predicate API instead of Guava's for event filtering.The framework version remained intact for now — in light of upcoming
pre3version.