Command handler contract enforcement #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmdashenkov
suggested changes
Jan 2, 2019
There was a problem hiding this comment.
@serhii-lekariev, please see if we could get rid of the extra check.
| DuplicateHandlerCheck.newInstance() | ||
| .check(classSet.elements()); | ||
| } | ||
|
|
||
| @SuppressWarnings("ResultOfMethodCallIgnored") | ||
| // `matches` either produces an exception, in which case return value can be ignored, | ||
| // or doesn't, in which case the execution continues |
There was a problem hiding this comment.
Please fix the alignment.
following their contract
…ment' into command-handler-contract-enforcement
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
============================================
+ Coverage 93.02% 93.05% +0.03%
- Complexity 3711 3715 +4
============================================
Files 508 508
Lines 12135 12143 +8
Branches 675 676 +1
============================================
+ Hits 11288 11300 +12
+ Misses 623 621 -2
+ Partials 224 222 -2 |
…tract-enforcement # Conflicts: # model/model-verifier/src/test/resources/build.gradle
dmdashenkov
reviewed
Jan 4, 2019
model/model-verifier/src/test/java/io/spine/model/verify/ModelVerifierTest.java
Outdated
Show resolved
Hide resolved
model/model-verifier/src/test/java/io/spine/model/verify/ModelVerifierTest.java
Show resolved
Hide resolved
model/model-verifier/src/test/java/io/spine/model/verify/given/InvalidRestoreAggregate.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/model/declare/MethodSignature.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/model/declare/MethodSignature.java
Outdated
Show resolved
Hide resolved
|
@dmdashenkov, PTAL again. |
dmdashenkov
approved these changes
Jan 4, 2019
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip |
There was a problem hiding this comment.
Please revert this change. We do not use all distributions as they slow down the CI builds.
| if (hasErrors) { | ||
| throw new SignatureMismatchException(mismatches); | ||
| } | ||
| if (!warnings.isEmpty()) { | ||
| warnings.stream().map(SignatureMismatch::toString).forEach(this::_warn); |
There was a problem hiding this comment.
Please format the call chain.
| return true; | ||
| } | ||
|
|
||
| private static boolean isWarning(SignatureMismatch mismatch){ | ||
| return mismatch.getSeverity() == WARN; |
There was a problem hiding this comment.
Looks like a method of SignatureMismatch. Together with isError(), this should enable us to delete getSeverity().
This was referenced Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
ModelVerifierto throw aSignatureMismatchExceptionwhen trying to verify a model that containsAggregatesthat declare command handlers that don't match the contract.Before,
ModelVerifierthrew an error upon finding a duplicate command handler (i.e. a handler that handles a command that is already handled), ignoring other invalid handlers.This PR also addresses existing warnings that are produced by the
ModelVerifier, by changing all existing subscriber method declarations to match the@Subscribecontract.