Fix for the migration #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's proving the point that regexes are not the ideal solution. It leads to assumptions being made, and potentially endless exceptions because it's not semantic. That's good for a hotfix, but I'd like to spend some time revisiting the migration code to improve its reliability and its "resistance" to tricky cases. |
|
BTW, there's a typo in the commit message (missing h for "has"), can you correct it and force-push on this branch before merging? |
The assumption that the name of the maven coordinate has at least 3 characters was incorrect. The group has at least 4 characters like "a.de" (and probably more). This way we can still differentiate with "hh::mm:ss" which is not a valid maven coordinate
jmfayard
force-pushed
the
migration-ui-fix
branch
from
49f5976
to
bfcc15e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @LouisCAD
Hello! I just tried to migrate a project that I freshly created from Android Studio BumbleBee Canary 9, selecting "Empty Compose Activity", and there was 2 problems: