Skip to content

Commit

Permalink
comment out unused code
Browse files Browse the repository at this point in the history
  • Loading branch information
SpontanCombust committed Sep 5, 2023
1 parent 7e851cb commit ab1f09f
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
14 changes: 7 additions & 7 deletions settings-parser/src/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ use crate::settings_var_type::SettingsVarType;


pub const GROUP_PARENT_CLASS: &str = "ISettingsGroup";
pub const GROUP_PARENT_MASTER_VAR_NAME: &str = "m_parentMaster";
// pub const GROUP_PARENT_MASTER_VAR_NAME: &str = "m_parentMaster";
pub const GROUP_ID_VAR_NAME: &str = "id";
pub const GROUP_DEFAULT_PRESET_VAR_NAME: &str = "defaultPresetIndex";
pub const GROUP_VALIDATE_VALUES_FUNC_NAME: &str = "ValidateSettings";
pub const GROUP_READ_SETTINGS_FUNC_NAME: &str = "ReadSettings";
pub const GROUP_WRITE_SETTINGS_FUNC_NAME: &str = "WriteSettings";
pub const GROUP_RESET_SETTINGS_TO_DEFAULT_FUNC_NAME: &str = "ResetSettingsToDefault";
// pub const GROUP_VALIDATE_VALUES_FUNC_NAME: &str = "ValidateSettings";
// pub const GROUP_READ_SETTINGS_FUNC_NAME: &str = "ReadSettings";
// pub const GROUP_WRITE_SETTINGS_FUNC_NAME: &str = "WriteSettings";
// pub const GROUP_RESET_SETTINGS_TO_DEFAULT_FUNC_NAME: &str = "ResetSettingsToDefault";
pub const GROUP_ENUM_MAPPING_VALIDATE_FUNC_NAME: &str = "EnumValueMappingValidateUnified";
pub const GROUP_VALIDATE_VALUES_PARSER_FUNC_NAME: &str = "Parser_ValidateSettings";
pub const GROUP_READ_SETTINGS_PARSER_FUNC_NAME: &str = "Parser_ReadSettings";
Expand All @@ -20,8 +20,8 @@ pub const GROUP_ENUM_MAPPING_VALIDATE_PARSER_FUNC_NAME: &str = "Parser_EnumValue
pub const MASTER_BASE_CLASS_NAME: &str = "ISettingsMaster";
pub const MASTER_MOD_VERSION_VAR_NAME: &str = "modVersion";
pub const MASTER_GROUP_ARRAY_VAR_NAME: &str = "m_groups";
pub const MASTER_READ_SETTING_VALUE_FUNC_NAME: &str = "ReadSettingValue";
pub const MASTER_WRITE_SETTING_VALUE_FUNC_NAME: &str = "WriteSettingValue";
// pub const MASTER_READ_SETTING_VALUE_FUNC_NAME: &str = "ReadSettingValue";
// pub const MASTER_WRITE_SETTING_VALUE_FUNC_NAME: &str = "WriteSettingValue";
pub const MASTER_INIT_PARSER_FUNC_NAME: &str = "Parser_Init";
pub const MASTER_SHOULD_RESET_TO_DEFAULT_ON_INIT_PARSER_FUNC_NAME: &str = "Parser_ShouldResetSettingsToDefaultOnInit";

Expand Down
16 changes: 8 additions & 8 deletions settings-parser/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ pub fn parse_attribute_number_required<N: FromStr>(node: &Node, attr: &'static s
}
}

pub fn parse_attribute_bool_required(node: &Node, attr: &'static str) -> Result<bool, String> {
let val = parse_attribute_bool(node, attr)?;
if let Some(val) = val {
Ok(val)
} else {
Err(format!("{} node at {} is missing {} attribute", node.tag_name().name(), node_pos(node), attr))
}
}
// pub fn parse_attribute_bool_required(node: &Node, attr: &'static str) -> Result<bool, String> {
// let val = parse_attribute_bool(node, attr)?;
// if let Some(val) = val {
// Ok(val)
// } else {
// Err(format!("{} node at {} is missing {} attribute", node.tag_name().name(), node_pos(node), attr))
// }
// }

0 comments on commit ab1f09f

Please sign in to comment.