Add lexical validation for variable not present #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebreach
reviewed
Jul 19, 2018
test/syntax.js
Outdated
| expect(validateExp('y<!2', scope)).to.deep.equal(["y variable not present", "cannot eval '!2' as value"]); | ||
| }) | ||
|
|
||
| it('should validate complex expression', function () { |
There was a problem hiding this comment.
what about checking that y is present and all..?
codebreach
reviewed
Jul 19, 2018
src/syntax.js
Outdated
| @@ -2,6 +2,8 @@ const operators = require('./operators.js')(isTruthy) | |||
| const lexical = require('./lexical.js') | |||
| const assert = require('../src/util/assert.js') | |||
|
|
|||
| const listOfOperators= ["=","!", "<", ">", "contains", "and", "or" ] | |||
There was a problem hiding this comment.
this is already defined as lexical.operators
also seems unused
codebreach
reviewed
Jul 19, 2018
| for (var i = 0; i < operatorREs.length; i++) { | ||
| var operatorRE = operatorREs[i] | ||
| var expRE = new RegExp(`^(${lexical.quoteBalanced.source})(${operatorRE.source})(${lexical.quoteBalanced.source})$`) | ||
| if ((match = exp.match(expRE))) { |
There was a problem hiding this comment.
can u autoformat this new code only?
like theres double (( here for no reason
| var match; | ||
| for (var i = 0; i < operatorREs.length; i++) { | ||
| var operatorRE = operatorREs[i] | ||
| var expRE = new RegExp(`^(${lexical.quoteBalanced.source})(${operatorRE.source})(${lexical.quoteBalanced.source})$`) |
There was a problem hiding this comment.
cant use template strings - this does not go through a transpiler
| if(scope.get(str) !== undefined && scope.get(str) !== null) { | ||
| return; | ||
| } else { | ||
| return `${str} variable not present` |
There was a problem hiding this comment.
don't use template strings?
i am not sure if they are safe. if we were using them before then you can keep them
There was a problem hiding this comment.
yes, we were using template strings in this module before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.