Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosts file had all *scdn* matches removed. #588

Closed
3 tasks done
ChromiaCat opened this issue Apr 30, 2024 · 5 comments
Closed
3 tasks done

Hosts file had all *scdn* matches removed. #588

ChromiaCat opened this issue Apr 30, 2024 · 5 comments
Labels
❌ bug Something isn't working

Comments

@ChromiaCat
Copy link

ChromiaCat commented Apr 30, 2024

🧐 Have you read the FAQ and viewed similar issues?

  • I have read the FAQ
  • I have checked older issues, open and closed
  • I did a clean install of SpotX as described in the FAQ

Сountry of your account

Greece

What is your Spotify Plan?

Free

Do you have Spicetify installed?

No

ℹ Computer information

- Spotify: 1.2.13.661.ga588f749
- Windows: 10 22H2 19045.2965
- PowerShell: 5.1.19041.2673

📝 Description

Basically the function that removes scdn matches from the hosts file will also remove matches that are not related to Spotify.

I know it backs up the file before but is there a way to know which lines it removed and/or ask if we want the changes to be written?

📸 Screenshots

No response

@ChromiaCat ChromiaCat added the ❌ bug Something isn't working label Apr 30, 2024
@amd64fox
Copy link
Member

amd64fox commented Apr 30, 2024

your backup copy of the hosts file is here

C:\Windows\System32\drivers\etc\hosts.bak

send a copy here

@ChromiaCat
Copy link
Author

your backup copy of the hosts file is here

C:\Windows\System32\drivers\etc\hosts.bak

send a copy here

I've already restored the copy and I've asked in the second sentence of the description if one or both solutions are easy to implement in the install script so users know what modifications are about to be done. I wouldn't make a bug issue if this was intended behavior.

@amd64fox
Copy link
Member

amd64fox commented May 1, 2024

all need to do in this case is improve the regex so that it only removes sdn lines associated with spotify, so earlier I asked you to demonstrate your hosts file that was restored

@ChromiaCat
Copy link
Author

all need to do in this case is improve the regex so that it only removes sdn lines associated with spotify, so earlier I asked you to demonstrate your hosts file that was restored

hosts.txt
This site is where I got them: https://someonewhocares.org/hosts/ipv6

@amd64fox
Copy link
Member

amd64fox commented May 2, 2024

fixed regex, thanks for the feedback

@amd64fox amd64fox closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants