Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding seqtk version 1.4 #822

Merged
merged 1 commit into from
Dec 26, 2023
Merged

adding seqtk version 1.4 #822

merged 1 commit into from
Dec 26, 2023

Conversation

erinyoung
Copy link
Contributor

There's a new version of seqtk!

From the release notes:

Notable changes:

Improvement: faster FASTX parsing (lh3/seqtk#123)

New feature: added the telo command to output telomere regions.

New feature: added the size command to count the number of sequences and
the number of bases. Lighter and thus faster than comp.

New feature: added the hpc command to compress homopolymers in input
sequences.

New feature: added the split command to split a large input file into
multiple smaller files.

New feature: added the gap command to output non-ACGT regions in the input
file.

New feature: added option -s to command subseq to support the strand
field in BED. For the moment, this option does not work with other subseq
options.

The version 1.3 Dockerfile was very old, so I used the Dockerfile_builder template instead. I added on a test stage and created a README.md for the tool as well.

seqtk does have an issue where there is no built in help option. The best I came up with is just to call the executable - which writes to stderr and Docker sees this as an error. I'm open to other workarounds, though.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor Author

Closes #673

Copy link
Collaborator

@Kincekara Kincekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Kincekara Kincekara merged commit f17108d into master Dec 26, 2023
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for your PR!
You can follow the deploy progress here: https://github.com/StaPH-B/docker-builds/actions/runs/7330098990

@erinyoung erinyoung deleted the erin-seqkit branch January 4, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants