Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAMECHEAP: Enable cmode concurrent #3202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tlimoncelli
Copy link
Contributor

CC @willpower232

  • Enable Concurrent mode for Namecheap

I did a limited amount of testing and it seems to work. I don't see any fields namecheap's struct that are updated after initialization.

@willpower232
Copy link
Contributor

Thanks @tlimoncelli I'll run some tests tomorrow if you like

@tlimoncelli
Copy link
Contributor Author

Thanks @tlimoncelli I'll run some tests tomorrow if you like

That'd be great!

A good test would be:

  • Compile with the -race flag: go install -race
  • Use a dnsconfig.js file with multiple namecheap domains (at least 3... the more the better)
  • Run the "race" version of the binary: dnscontrol preview --cmode concurrent

Thanks!
Tom

@willpower232
Copy link
Contributor

CONCURRENTLY gathering 5 zone(s)
SERIALLY gathering 18 zone(s)

I have 5 zones using both Namecheap DNS and registrar so looking good to me! I even ran it in a loop to offend the rate limit and that worked nicely too.

I'm using 3 other DNS providers but they don't have concurrency ticked on the docs so everything lines up.

Anything else you need me to try?

@tlimoncelli
Copy link
Contributor Author

tlimoncelli commented Nov 16, 2024 via email

@willpower232
Copy link
Contributor

Ah of course, I have tried netlify, hetzner, and digital ocean with no problem. The preview sure is fast now!

CONCURRENTLY gathering 23 zone(s)
SERIALLY gathering 0 zone(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants