Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flanker dependencies break sensors with py2 #27

Closed
punkrokk opened this issue Dec 10, 2019 · 0 comments · Fixed by #29
Closed

Flanker dependencies break sensors with py2 #27

punkrokk opened this issue Dec 10, 2019 · 0 comments · Fixed by #29

Comments

@punkrokk
Copy link
Contributor

Problem: The otherwise amazing flanker package does not pin a version of the tld package. The last version to support py2 is v0.10.

This results in a state when installing the email pack st2 pack install email where tld 0.11 is installed and since we are using sensors - things fail since they need to be py2.

In good news - flanker was pinned flanker>=0.9.0 so other needing the tld package pinned for py2, this will be a low risk change.

Solution: @bradchiappetta and I have forked flanker from and pinned tld==0.10 and tested in a clean install st2 pack install email.

We have also created a PR to the flanker project and will update this pack once our change is merged.

punkrokk added a commit to syncurity-exchange/stackstorm-email that referenced this issue Dec 10, 2019
@blag blag mentioned this issue Dec 11, 2019
@blag blag closed this as completed in #29 Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant