Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment for updateSampleInterval. #112

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Fix comment for updateSampleInterval. #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions retrieval/series_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type seriesGetter interface {
getResetAdjusted(ref uint64, t int64, v float64) (int64, float64, bool)

// Attempt to set the new most recent time range for the series with given hash.
// Returns true if it failed, in which case the sample must be discarded.
// Returns false if it failed, in which case the sample must be discarded.
updateSampleInterval(hash uint64, start, end int64) bool
}

Expand Down Expand Up @@ -251,7 +251,7 @@ func (c *seriesCache) get(ctx context.Context, ref uint64) (*seriesCacheEntry, b
}

// updateSampleInterval attempts to set the new most recent time range for the series with given hash.
// Returns true if it failed, in which case the sample must be discarded.
// Returns false if it failed, in which case the sample must be discarded.
func (c *seriesCache) updateSampleInterval(hash uint64, start, end int64) bool {
iv, ok := c.intervals[hash]
if !ok || iv.accepts(start, end) {
Expand Down