Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented parameters to DropTargetLabels #120

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Documented parameters to DropTargetLabels #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions retrieval/series_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,9 @@ func (c *seriesCache) refresh(ctx context.Context, ref uint64) error {
return nil
}
// Remove target labels and __name__ label.
// Stackdriver only accepts a limited amount of labels, so we choose to economize aggressively here. This should be OK
jkohen marked this conversation as resolved.
Show resolved Hide resolved
// because we expect that the target.Labels will be redundant with the Stackdriver MonitoredResource, which is derived
// from the target Labels and DiscoveredLabels.
finalLabels := targets.DropTargetLabels(pkgLabels(entry.lset), target.Labels)
for i, l := range finalLabels {
if l.Name == "__name__" {
Expand Down