Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debug logging when resource name cannot be detected. #122

Merged
merged 1 commit into from
May 10, 2019
Merged

Improve debug logging when resource name cannot be detected. #122

merged 1 commit into from
May 10, 2019

Conversation

knyar
Copy link
Contributor

@knyar knyar commented May 10, 2019

This expands log message with discovered labels as well, which makes
debugging 'unknown_resource' errors easier.

@knyar
Improve debug logging when resource name cannot be detected.
f1314d6 
This expands log message with discovered labels as well, which makes
debugging 'unknown_resource' errors easier.
@jkohen jkohen self-requested a review May 10, 2019 12:56
jkohen
jkohen approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@jkohen jkohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkohen jkohen merged commit e00aaf5 into Stackdriver:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkohen jkohen jkohen approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knyar @jkohen @googlebot