Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'v' prefix in release tag. #126

Merged
merged 1 commit into from
May 17, 2019
Merged

Remove 'v' prefix in release tag. #126

merged 1 commit into from
May 17, 2019

Conversation

StevenYCChou
Copy link
Contributor

Align with Stackdriver agents version schema.

@StevenYCChou
Remove 'v' prefix in release tag.
bc1d1f3 
Align with Stackdriver agents version schema.
@StevenYCChou StevenYCChou requested a review from jkohen May 17, 2019 16:32
jkohen
jkohen approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@jkohen jkohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we discussed this before and we thought it could create ambiguity in some command-line tools. As long as all the tooling works, I'm fine with this.

@StevenYCChou
Copy link
Contributor Author

The one ambiguity I know for tool is that branch and tag cannot share the same name, otherwise it creates confusion for git. With this change, release branch and tag still has different name so it shouldn't be an issue.

@StevenYCChou StevenYCChou merged commit 07919eb into Stackdriver:master May 17, 2019
@StevenYCChou StevenYCChou deleted the ycchou-remove-version-prefix branch May 17, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkohen jkohen jkohen approved these changes

Assignees

@qingling128 qingling128

@jkohen jkohen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StevenYCChou @jkohen @qingling128 @googlebot