fix cache lookups and name sensing for recorded metrics #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for most of the issues noted in Stackdriver#104 - update targets.targetMatch() to match labels correctly in the case of a recorded metric (thank you @StevenYCChou) - update metadata.Cache.Get() to treat metrics with names prefixed with the value of the `--stackdriver.recorded-metric-prefix` flag (default: `recorded_`) as recorded metrics and log an error if a colon is found in the metric name (stackdriver metric names cannot have those) - update README with specific notes for forwarding recorded metrics
|
n.b. the build failure appears to be unrelated to this PR as far as I can tell |
|
Superseded by #266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for most of the issues noted in #104
update targets.targetMatch() to match labels correctly in
the case of a recorded metric (thank you @StevenYCChou)
update metadata.Cache.Get() to treat metrics with names prefixed with
the value of the
--stackdriver.recorded-metric-prefixflag (default:recorded_) as recorded metrics and log an error if a colon is found inthe metric name (stackdriver metric names cannot have those)
update README with specific notes for forwarding recorded metrics