Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat the Compatibility table. #172

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Reformat the Compatibility table. #172

merged 1 commit into from
Sep 10, 2019

Conversation

StevenYCChou
Copy link
Contributor

The existing table will render table header on Prometheus 2.7 incorrectly as it will show as

** Prometheus 2.7 **

This change should fix the format.

I also ensure spaces before and after the header text.

@StevenYCChou StevenYCChou self-assigned this Sep 10, 2019
qingling128
qingling128 approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StevenYCChou StevenYCChou merged commit 27e127a into master Sep 10, 2019
@StevenYCChou StevenYCChou deleted the StevenYCChou-patch-1 branch September 10, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

@jkschulz jkschulz Awaiting requested review from jkschulz

Assignees

@StevenYCChou StevenYCChou

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StevenYCChou @qingling128 @googlebot