Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replace logic for thrift repo. #177

Closed
wants to merge 1 commit into from
Closed

Remove replace logic for thrift repo. #177

wants to merge 1 commit into from

Conversation

StevenYCChou
Copy link
Contributor

Fixes #176 .

@StevenYCChou StevenYCChou self-assigned this Sep 24, 2019
@qingling128
Copy link
Contributor

Is my understanding correct that this PR fixed the issue because git.apache.org is back online?

@StevenYCChou
Copy link
Contributor Author

Is my understanding correct that this PR fixed the issue because git.apache.org is back online?
Yes.

However, I couldn't reproduce the issue of #176 anymore. Seems like make test will work now.

I think the TODO comment you left are still valid if git.apache.org goes down, so I'd like to keep the replacement logic. Will close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 Awaiting requested review from qingling128

Assignees

@StevenYCChou StevenYCChou

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test fails caused by github.com/apache/thrift and git.apache.org/thrift.git
3 participants
@StevenYCChou @qingling128 @googlebot