Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation #187

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Fixed compilation #187

merged 1 commit into from
Oct 17, 2019

Conversation

jkohen
Copy link
Contributor

@jkohen jkohen commented Oct 17, 2019

The thrift alias was giving this error:

GO111MODULE=on go test  -mod=vendor ./...
?       github.com/Stackdriver/stackdriver-prometheus-sidecar/bench     [no test files]
compilation error :go: github.com/apache/thrift@v0.12.0 used for two different module paths (git.apache.or
g/thrift.git and github.com/apache/thrift)                                                               
 
FAIL    github.com/Stackdriver/stackdriver-prometheus-sidecar/cmd/stackdriver-prometheus-sidecar        0.
364s                                                                                                     

The thrift alias was giving this error:
```
GO111MODULE=on go test  -mod=vendor ./...
?       github.com/Stackdriver/stackdriver-prometheus-sidecar/bench     [no test files]
compilation error :go: github.com/apache/thrift@v0.12.0 used for two different module paths (git.apache.or
g/thrift.git and github.com/apache/thrift)                                                               
 
FAIL    github.com/Stackdriver/stackdriver-prometheus-sidecar/cmd/stackdriver-prometheus-sidecar        0.
364s                                                                                                     
```
@jkohen jkohen requested a review from qingling128 October 17, 2019 16:54
@jkohen jkohen self-assigned this Oct 17, 2019
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jkohen jkohen merged commit e9310a7 into master Oct 17, 2019
@jkohen jkohen deleted the jkohen-patch-1 branch October 17, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants