Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for proxy and devapp monitored resources #189

Merged
merged 15 commits into from
Oct 21, 2019
Merged

Conversation

jkohen
Copy link
Contributor

@jkohen jkohen commented Oct 17, 2019

This required support for using metric labels as input to the monitored resource, which I did in this change.

@jkohen jkohen requested a review from StevenYCChou October 17, 2019 21:32
@jkohen jkohen self-assigned this Oct 17, 2019
retrieval/series_cache.go Outdated Show resolved Hide resolved
retrieval/series_cache.go Outdated Show resolved Hide resolved
retrieval/resource_map.go Outdated Show resolved Hide resolved
retrieval/resource_map.go Show resolved Hide resolved
retrieval/resource_map.go Outdated Show resolved Hide resolved
@jkohen jkohen requested a review from StevenYCChou October 18, 2019 15:43
Copy link
Contributor

@StevenYCChou StevenYCChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the new updates.

@jkohen jkohen merged commit 65ff039 into master Oct 21, 2019
@jkohen jkohen deleted the apigee branch October 21, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants