Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run goveralls on internal pull requests. #274

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Only run goveralls on internal pull requests. #274

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c76ea0
Only run goveralls on internal pull requests.
igorpeshansky Feb 25, 2021
de84574
Comment fixes.
igorpeshansky Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ go_import_path: github.com/Stackdriver/stackdriver-prometheus-sidecar
# Skip dependency fetch. We store all dependencies under vendor/.
install: true

# make goveralls runs all tests as well.
script:
- make goveralls
# Can't run goveralls from external pull requests.
- 'if [[ "${TRAVIS_PULL_REQUEST_SLUG:-Stackdriver/stackdriver-prometheus-sidecar}" != "Stackdriver/stackdriver-prometheus-sidecar" ]]; then make test; fi'
# make goveralls runs all tests as well.
igorpeshansky marked this conversation as resolved.
Show resolved Hide resolved
- 'if [[ "${TRAVIS_PULL_REQUEST_SLUG:-Stackdriver/stackdriver-prometheus-sidecar}" == "Stackdriver/stackdriver-prometheus-sidecar" ]]; then make goveralls; fi'
# TODO(jkohen): `make goveralls` is causing a diff in go.mod. Prevent that and uncomment the line below.
#- git diff --exit-code

Expand Down