Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show respective Heart Health Segment on tap on dashboard #93

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

pauljohanneskraft
Copy link
Contributor

@pauljohanneskraft pauljohanneskraft commented Sep 25, 2024

Show respective Heart Health Segment on tap on dashboard

♻️ Current situation & Problem

Previously, a user could not select any items in the "Recent Vitals" section on the dashboard. We received feedback suggesting that users would like to open the respective charts on tap of each of these cards on the dashboard.

Currently, I moved the state into NavigationManager. I'm not entirely sure whether this is the right spot, since it is somewhat separate from that... I was also thinking about VitalsManager, but it doesn't really do any transition logic, but only fetching data and preparing it for display, so I'm open for discussing about this.

⚙️ Release Notes

  • Make recent vitals cards on dashboard tappable. Tapping a card leads to the respective chart on the Heart Health Page.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft changed the title Select Heart Show respective Heart Health Segment on tap on dashboard Sep 25, 2024
@pauljohanneskraft pauljohanneskraft self-assigned this Sep 25, 2024
@pauljohanneskraft pauljohanneskraft added the enhancement New feature or request label Sep 25, 2024
@pauljohanneskraft pauljohanneskraft marked this pull request as ready for review September 25, 2024 16:14
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (4d18f94) to head (207528d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   78.10%   78.07%   -0.02%     
==========================================
  Files         144      144              
  Lines        4975     4992      +17     
==========================================
+ Hits         3885     3897      +12     
- Misses       1090     1095       +5     
Files with missing lines Coverage Δ
...NGAGEHF/Dashboard/Vitals/RecentVitalsSection.swift 96.37% <100.00%> (+0.45%) ⬆️
ENGAGEHF/HeartHealth/HeartHealth.swift 100.00% <100.00%> (+5.89%) ⬆️
...Managers/NavigationManager/NavigationManager.swift 88.61% <100.00%> (+0.61%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d18f94...207528d. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool; thank you for the additions @pauljohanneskraft!

@pauljohanneskraft pauljohanneskraft enabled auto-merge (squash) October 3, 2024 20:16
@pauljohanneskraft pauljohanneskraft merged commit 7ee5b83 into main Oct 3, 2024
8 checks passed
@pauljohanneskraft pauljohanneskraft deleted the redirect-dashboard-vitals-to-vitals branch October 3, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants