Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Spezi 1.2.0 and Improve Background Sample Delivery #19

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

PSchmiedmayer
Copy link
Member

Update to Spezi 1.2.0 and Improve Background Sample Delivery

♻️ Current situation & Problem

  • HealthKit datatypes are not delivered on the first launch of the app if the settings are set to background mode
  • Spezi 1.2.0 simplified the lifecycle of Spezi Modules

⚙️ Release Notes

  • Fixes the issue that HealthKit datatypes are not delivered on the first launch of the app if the settings are set to background mode
  • Updates to Spezi 1.2.0

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Mar 6, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 68.90%. Comparing base (4252621) to head (7463a86).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   69.90%   68.90%   -0.99%     
==========================================
  Files          11       11              
  Lines         455      463       +8     
==========================================
+ Hits          318      319       +1     
- Misses        137      144       +7     
Files Coverage Δ
...s/SpeziHealthKit/CollectSample/CollectSample.swift 100.00% <ø> (ø)
...hKit/HealthKitDataSource/HealthKitDataSource.swift 100.00% <ø> (ø)
...hKitDeliverySetting/HealthKitDeliverySetting.swift 100.00% <ø> (ø)
Sources/SpeziHealthKit/HealthKit.swift 76.75% <85.72%> (ø)
... Extensions/HKHealthStore+BackgroundDelivery.swift 58.63% <72.73%> (ø)
...hKit/CollectSample/HealthKitSampleDataSource.swift 93.59% <84.62%> (-2.73%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4252621...7463a86. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 3562808 into main Mar 8, 2024
8 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/background branch March 8, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant