Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #59 removed video description nullability #134

Merged
merged 8 commits into from
Nov 9, 2024

Conversation

Basler182
Copy link
Contributor

removed video description nullability

♻️ Current situation & Problem

#59

⚙️ Release Notes

The mapper is adapted so that it does not accept videos without a description and the model is adapted accordingly so that it no longer accepts null values and the null check is removed in the code

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Signed-off-by: Basler182 <showdialog@web.de>
@Basler182 Basler182 added enhancement New feature or request ENGAGE HF ENGAGE-HF-specific issues labels Oct 26, 2024
@Basler182 Basler182 self-assigned this Oct 26, 2024
@Basler182 Basler182 linked an issue Oct 26, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.48%. Comparing base (f7effec) to head (6aaf89f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cation/VideoSectionDocumentToVideoSectionMapper.kt 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #134      +/-   ##
============================================
+ Coverage     39.47%   39.48%   +0.02%     
- Complexity      791      792       +1     
============================================
  Files           265      265              
  Lines         10533    10532       -1     
  Branches       1480     1479       -1     
============================================
+ Hits           4157     4158       +1     
  Misses         6014     6014              
+ Partials        362      360       -2     
Flag Coverage Δ
uitests 33.50% <100.00%> (-0.01%) ⬇️
unittests 33.35% <30.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nford/spezi/modules/education/video/VideoScreen.kt 59.10% <100.00%> (+0.27%) ⬆️
...spezi/modules/education/videos/EducationUiState.kt 86.37% <100.00%> (ø)
...cation/VideoSectionDocumentToVideoSectionMapper.kt 83.88% <66.67%> (+3.88%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7effec...6aaf89f. Read the comment docs.

Signed-off-by: Basler182 <showdialog@web.de>
@Basler182 Basler182 requested a review from eldcn October 27, 2024 10:57
@Basler182
Copy link
Contributor Author

as far as i have seen, all videos already have a description. as soon as this is completely fixed, you are welcome to merge it @pauljohanneskraft

@Basler182 Basler182 marked this pull request as ready for review October 27, 2024 10:59
Copy link
Contributor

@eldcn eldcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed look good from my side 🚀 Let's wait for @pauljohanneskraft confirmation before merging

@eldcn
Copy link
Contributor

eldcn commented Nov 9, 2024

We just confirmed this with @pauljohanneskraft that field is not nullable anymore, and the description will always be available. Merging :)

@eldcn eldcn merged commit 5009495 into main Nov 9, 2024
11 checks passed
@eldcn eldcn deleted the task/video-description-nullabillity-issue-59 branch November 9, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENGAGE HF ENGAGE-HF-specific issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video Description can't be null in future
3 participants