-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #59 removed video description nullability #134
Conversation
Signed-off-by: Basler182 <showdialog@web.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
============================================
+ Coverage 39.47% 39.48% +0.02%
- Complexity 791 792 +1
============================================
Files 265 265
Lines 10533 10532 -1
Branches 1480 1479 -1
============================================
+ Hits 4157 4158 +1
Misses 6014 6014
+ Partials 362 360 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Basler182 <showdialog@web.de>
as far as i have seen, all videos already have a description. as soon as this is completely fixed, you are welcome to merge it @pauljohanneskraft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed look good from my side 🚀 Let's wait for @pauljohanneskraft confirmation before merging
We just confirmed this with @pauljohanneskraft that field is not nullable anymore, and the description will always be available. Merging :) |
removed video description nullability
♻️ Current situation & Problem
#59
⚙️ Release Notes
The mapper is adapted so that it does not accept videos without a description and the model is adapted accordingly so that it no longer accepts null values and the null check is removed in the code
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: