Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #90 don't dismiss failed message action #137

Merged
merged 16 commits into from
Nov 3, 2024

Conversation

Basler182
Copy link
Contributor

don't dismiss failed message action

♻️ Current situation & Problem

#90

⚙️ Release Notes

  • don't dismiss failed message action

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Signed-off-by: Basler182 <showdialog@web.de>
Signed-off-by: Basler182 <showdialog@web.de>
Signed-off-by: Basler182 <showdialog@web.de>
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.47%. Comparing base (891883b) to head (2ab75c3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nford/bdh/engagehf/bluetooth/BluetoothViewModel.kt 69.57% 2 Missing and 5 partials ⚠️
...ezi/modules/education/videos/EducationViewModel.kt 28.58% 3 Missing and 2 partials ⚠️
.../spezi/modules/education/videos/EducationScreen.kt 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #137      +/-   ##
============================================
+ Coverage     39.47%   39.47%   +0.01%     
- Complexity      785      791       +6     
============================================
  Files           265      265              
  Lines         10524    10533       +9     
  Branches       1476     1480       +4     
============================================
+ Hits           4153     4157       +4     
- Misses         6010     6014       +4     
- Partials        361      362       +1     
Flag Coverage Δ
uitests 33.52% <20.00%> (-0.05%) ⬇️
unittests 33.32% <54.55%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...spezi/modules/education/videos/EducationUiState.kt 86.37% <100.00%> (ø)
.../spezi/modules/education/videos/EducationScreen.kt 40.91% <50.00%> (ø)
...ezi/modules/education/videos/EducationViewModel.kt 59.53% <28.58%> (+1.63%) ⬆️
...nford/bdh/engagehf/bluetooth/BluetoothViewModel.kt 75.61% <69.57%> (-1.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891883b...2ab75c3. Read the comment docs.

Signed-off-by: Basler182 <showdialog@web.de>
Signed-off-by: Basler182 <showdialog@web.de>
@Basler182 Basler182 self-assigned this Oct 27, 2024
@Basler182 Basler182 added the ENGAGE HF ENGAGE-HF-specific issues label Oct 27, 2024
@Basler182 Basler182 marked this pull request as ready for review October 27, 2024 20:50
@Basler182 Basler182 requested a review from eldcn October 30, 2024 21:22
Basler182 and others added 6 commits November 3, 2024 11:55
Signed-off-by: Basler182 <showdialog@web.de>
Signed-off-by: Basler182 <showdialog@web.de>
…andling

# Conflicts:
#	app/src/main/res/values/strings.xml
Signed-off-by: Basler182 <showdialog@web.de>
Signed-off-by: Basler182 <showdialog@web.de>
Signed-off-by: Basler182 <showdialog@web.de>
@Basler182 Basler182 requested a review from eldcn November 3, 2024 13:14
Copy link
Contributor

@eldcn eldcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Basler182 Basler182 merged commit f7effec into main Nov 3, 2024
11 checks passed
@Basler182 Basler182 deleted the task/message-action-handling branch November 3, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENGAGE HF ENGAGE-HF-specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants