SpeziAccount #639

Sign in to view logs

GitHub Actions / detekt failed Nov 12, 2024 in 1s

reviewdog [detekt] report

reported by reviewdog 🐶

Findings (19)

modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt|68 col 20| This empty block of code can be removed.
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt|74 col 53| This empty block of code can be removed.
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt|127 col 25| Private function updateDisplayName is unused.
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/keys/PasswordKey.kt|69 col 1| Unexpected blank line(s) before "}"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/collections/AccountDetailsSerializer.kt|67 col 28| Missing trailing comma before ")"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/ExternalAccountStorage.kt|15 col 57| Missing trailing comma before ")"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt|8 col 1| Unused import
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt|8 col 1| The import 'androidx.compose.ui.graphics.Color' is unused.
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt|12 col 44| Missing trailing comma before ")"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt|7 col 1| Needless blank line(s)
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/compositionLocal/SignUpProviderCompliance.kt|56 col 36| Missing trailing comma before ")"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt|213 col 1| Needless blank line(s)
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt|328 col 1| Needless blank line(s)
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt|58 col 36| Missing trailing comma before ")"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt|118 col 108| Missing trailing comma before ")"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt|368 col 38| Missing trailing comma before ")"
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt|344 col 17| Function names should match the pattern: ([a-z][a-zA-Z0-9]*)|(.*)
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt|17 col 1| Unused import
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt|17 col 1| The import 'androidx.compose.ui.text.input.TextFieldValue' is unused.

Filtered Findings (0)

Annotations

Check warning on line 68 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt#L68 <detekt.EmptyElseBlock>

This empty block of code can be removed.

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt:68:20: warning: This empty block of code can be removed. (detekt.EmptyElseBlock)

Check warning on line 74 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt#L74 <detekt.EmptyFunctionBlock>

This empty block of code can be removed.

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt:74:53: warning: This empty block of code can be removed. (detekt.EmptyFunctionBlock)

Check warning on line 127 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt#L127 <detekt.UnusedPrivateMember>

Private function `updateDisplayName` is unused.

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/firebase/account/FirebaseAccountService.kt:127:25: warning: Private function `updateDisplayName` is unused. (detekt.UnusedPrivateMember)

Check warning on line 69 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/keys/PasswordKey.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/keys/PasswordKey.kt#L69 <detekt.NoBlankLineBeforeRbrace>

Unexpected blank line(s) before "}"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/keys/PasswordKey.kt:69:1: warning: Unexpected blank line(s) before "}" (detekt.NoBlankLineBeforeRbrace)

Check warning on line 67 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/collections/AccountDetailsSerializer.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/collections/AccountDetailsSerializer.kt#L67 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/value/collections/AccountDetailsSerializer.kt:67:28: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 15 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/ExternalAccountStorage.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/ExternalAccountStorage.kt#L15 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/ExternalAccountStorage.kt:15:57: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 8 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt#L8 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt:8:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 8 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt#L8 <detekt.UnusedImports>

The import 'androidx.compose.ui.graphics.Color' is unused.

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/documentation/DocumentationInfoView.kt:8:1: warning: The import 'androidx.compose.ui.graphics.Color' is unused. (detekt.UnusedImports)

Check warning on line 12 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt#L12 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt:12:44: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 7 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt#L7 <detekt.NoConsecutiveBlankLines>

Needless blank line(s)

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/views/setup/provider/AccountSetupProviderComposable.kt:7:1: warning: Needless blank line(s) (detekt.NoConsecutiveBlankLines)

Check warning on line 56 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/compositionLocal/SignUpProviderCompliance.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/compositionLocal/SignUpProviderCompliance.kt#L56 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/compositionLocal/SignUpProviderCompliance.kt:56:36: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 213 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt#L213 <detekt.NoConsecutiveBlankLines>

Needless blank line(s)

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt:213:1: warning: Needless blank line(s) (detekt.NoConsecutiveBlankLines)

Check warning on line 328 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt#L328 <detekt.NoConsecutiveBlankLines>

Needless blank line(s)

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt:328:1: warning: Needless blank line(s) (detekt.NoConsecutiveBlankLines)

Check warning on line 58 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt#L58 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt:58:36: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 118 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt#L118 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt:118:108: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 368 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt#L368 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt:368:38: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 344 in modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt

github-actions / detekt

[detekt] modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt#L344 <detekt.FunctionNaming>

Function names should match the pattern: ([a-z][a-zA-Z0-9]*)|(`.*`)

Raw output


            /github/workspace/modules/account/src/main/kotlin/edu/stanford/spezi/module/account/account/mock/InMemoryAccountService.kt:344:17: warning: Function names should match the pattern: ([a-z][a-zA-Z0-9]*)|(`.*`) (detekt.FunctionNaming)

Check warning on line 17 in core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt

github-actions / detekt

[detekt] core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt#L17 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt:17:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 17 in core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt

github-actions / detekt

[detekt] core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt#L17 <detekt.UnusedImports>

The import 'androidx.compose.ui.text.input.TextFieldValue' is unused.

Raw output


            /github/workspace/core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt:17:1: warning: The import 'androidx.compose.ui.text.input.TextFieldValue' is unused. (detekt.UnusedImports)

View more details on GitHub Actions