Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LocalStorage and SecureStorage Sendable #22

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 2, 2024

Make LocalStorage and SecureStorage Sendable

♻️ Current situation & Problem

This PR adds Sendable conformance for both storage modules.

⚙️ Release Notes

  • LocalStorage is now Sendable
  • SecureStorage is now Sendable

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (9d04bc6) to head (d004ea5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files           6        6           
  Lines         453      453           
=======================================
  Hits          417      417           
  Misses         36       36           
Files Coverage Δ
Sources/SpeziLocalStorage/LocalStorage.swift 89.43% <ø> (ø)
Sources/SpeziSecureStorage/SecureStorage.swift 93.97% <ø> (ø)
...es/SpeziSecureStorage/SecureStorageItemTypes.swift 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d04bc6...d004ea5. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg for ensuring sendable conformance!

Sources/SpeziLocalStorage/LocalStorage.swift Show resolved Hide resolved
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Aug 2, 2024
@Supereg Supereg merged commit 52bd5cb into main Aug 6, 2024
19 checks passed
@Supereg Supereg deleted the feature/sendable-modules branch August 6, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants