Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable wayland feature for bevy in dev #556

Merged

Conversation

@teohhanhui
Copy link
Contributor Author

teohhanhui commented Sep 3, 2024

@teohhanhui teohhanhui force-pushed the enable/wayland-in-dev branch 2 times, most recently from e4e8c03 to cd48d32 Compare September 3, 2024 16:21
@teohhanhui teohhanhui force-pushed the enable/wayland-in-dev branch from cd48d32 to c9a2dbe Compare September 3, 2024 20:20
@teohhanhui
Copy link
Contributor Author

Oops... Missed adding the step for the clippy job...

@ChristopherBiscardi
Copy link
Collaborator

bevyengine/bevy#10792 (comment) states that

Defaulting to Wayland will break Bevy for Wayland users with no access to Vulkan drivers.

I largely don't have an opinion on doing this for dev. It looks like the current state of things is we either potentially break one group of users or another group of users (until bevy merges the fix upstream), but wayland is the future so I'm a soft +1.

Would like to get thoughts from @rparrett though.

Copy link
Collaborator

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with doing this before Bevy if it helps out the people who want to work on bevy_ecs_tilemap now.

@teohhanhui
Copy link
Contributor Author

teohhanhui commented Sep 16, 2024

Defaulting to Wayland will break Bevy for Wayland users with no access to Vulkan drivers.

Actually no, it's already broken. If you're on Wayland, and have no Vulkan driver, nothing would help at this time. Every possible combination is broken.

XWayland + OpenGL does not work: bevyengine/bevy#13753 (comment) and bevyengine/bevy#8788 (comment)

Wayland + OpenGL does not work: bevyengine/bevy#13923

@ChristopherBiscardi ChristopherBiscardi merged commit 7ebe37b into StarArawn:main Sep 16, 2024
8 checks passed
@ChristopherBiscardi
Copy link
Collaborator

merging then, we can re-evaluate if bevy changes upstream. thanks @teohhanhui !

@teohhanhui teohhanhui deleted the enable/wayland-in-dev branch September 16, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants