feat: add newly introduced prometheus no-auth flag #203
Conversation
Adds a recently introduced flag jupyter/notebook@c0ab18a which allows us to keep accessing the `/metrics` endpoint.
|
There are a lot of whitespace edits (I guess vs-code cleaned up some whitespace on my behalf), but the only actual change is line 71 of the entrypoint script. |
|
Converted to draft while I build and test the images to be 100% certain there are no breaking changes on previous versions. |
|
@blairdrummond Can you link this to an issue? |
|
And my approved PR |
It's not an issue yet because we aren't on those images yet, but once we upgrade our jupyter images, /metrics will give 403s |
|
@blairdrummond I think @brendangadd meant to link this to the issue of ours that comes out of, which I guess would be metrics collection. But yeah Brendan I agree with Blair there isn't necessarily an issue that correlates 1:1 with this |
Adds a new flag
jupyter/notebook@c0ab18a
Which would otherwise prevent us from scraping
/metrics.(We currently can scrape metrics, but this will break once we upgrade to the newer docker-stacks base images.)