Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jq errors in prerelease script #118

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

bycEEE
Copy link
Contributor

@bycEEE bycEEE commented Jul 15, 2022

The current https://raw.githubusercontent.com/SteamDeckHomebrew/decky-loader/main/dist/install_prerelease.sh script doesn't work and errors out when trying to execute.

(deck@breezydeck ~)$ ./install_prerelease.sh
Installing Steam Deck Plugin Loader pre-release...
./install_prerelease.sh: line 16: [: too many arguments
curl: no URL specified!
curl: try 'curl --help' for more information

This is a quick fix to pass in the variables to jq correctly to rectify this issue.

@bycEEE
Copy link
Contributor Author

bycEEE commented Jul 15, 2022

Second commit has the following changes:

  • Add back the removed $RELEASE variable in case you want to use it later for something else.
  • Assign multiple variables at once instead of calling jq again for each one.
  • Follow the variable expansion paradigm already set (eg: $RELEASE -> ${RELEASE}.
  • Add version number in installation output.
    Installing Steam Deck Plugin Loader pre-release...
    Installing version v2.0.4-pre...
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
    100 18.1M  100 18.1M    0     0  12.0M      0  0:00:01  0:00:01 --:--:-- 23.6M
    Created symlink /etc/systemd/system/multi-user.target.wants/plugin_loader.service → /etc/systemd/system/plugin_loader.service.
    

@AAGaming00 AAGaming00 merged commit ba824fc into SteamDeckHomebrew:main Jul 15, 2022
KP2048 pushed a commit to EmuDeck/decky-loader that referenced this pull request May 4, 2023
* Fix jq errors in prerelease script

* Use multivariable output, add back RELEASE var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants