Rewrite router/tabs/toaster hooks #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAGaming00
added
enhancement
4 tasks
AAGaming00
force-pushed
the
aa/new-hooks
branch
2 times, most recently
from
af93263
to
8d3c6cb
Compare
AAGaming00
changed the title
|
The tabs hook silently failed once when testing this, but i haven't been able to replicate it yet. Could use some help testing. |
|
Should be ready for review and testing now. |
suchmememanyskill
approved these changes
Jul 29, 2024
This comment was marked as outdated.
This comment was marked as outdated.
AAGaming00
force-pushed
the
aa/new-hooks
branch
from
0a5062a
to
c6256b3
Compare
this also supports the notification list and probably also desktop toasts (UI wip, read location enum prop from toast component probably)
could still use some padding but eh
we need to write one for SteamClient.System.OpenFileDialog eventually
AAGaming00
force-pushed
the
aa/new-hooks
branch
from
cc8aafb
to
f54b21e
Compare
AAGaming00
force-pushed
the
aa/new-hooks
branch
from
f54b21e
to
d444248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
This fixes many issues with the current router/toaster/tabs hooks (such as toasts breaking after exiting sleep), adds desktop BPM support to the router/toaster/tabs hooks, adds desktop support to the toaster hook, and adds preliminary support for a future desktop UI router hook.
The new toaster hook also supports displaying toasts in the QAM's notification tray.
Current blocking issues:
- [x] Investigate occasional react error when injecting into the router too earlyI can't reproduce this anymore.Here's an example of toasts working in the tray (UI is WIP)
Potentially breaking changes