Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor install script #69

Conversation

TrainDoctor
Copy link
Member

@TrainDoctor TrainDoctor commented May 30, 2022

Allows users to run a script that will add their in development version onto the deck in a way which they can test easily.
deck.sh is firmcoded for the deck since it is intended for testing on Deck, while pc.sh is flexible for other platforms.

Both scripts request almost all information needed for them to function properly but can be ran with parameters in order to bypass prompts.

More information here.

About deck.sh:

Before using deck.sh, I recommend that you enable sshd on the deck and setup an sshd key between the deck and your dev in sshd_config.
(key is optional but recommended)
This script defaults to port 22 unless otherwise specified, and cannot run without a sudo password or LAN IP.
You will need to specify the path to the ssh key if using key connection exclusively.

@TrainDoctor TrainDoctor marked this pull request as ready for review May 30, 2022 03:00
@TrainDoctor TrainDoctor added this to the React Update milestone Jun 1, 2022
@TrainDoctor TrainDoctor added the enhancement New feature or request label Jun 1, 2022
@TrainDoctor TrainDoctor self-assigned this Jun 1, 2022
@TrainDoctor TrainDoctor requested a review from a team June 1, 2022 22:15
README.md Show resolved Hide resolved
dist/install_contrib_deck.sh Outdated Show resolved Hide resolved
dist/install_contrib_pc.sh Outdated Show resolved Hide resolved
dist/install_contrib_pc.sh Outdated Show resolved Hide resolved
Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will finish this review tomorrow, marking as changes requested for now.

README.md Show resolved Hide resolved
dist/install_contrib_pc.sh Outdated Show resolved Hide resolved
@TrainDoctor TrainDoctor added the requires documentation requires documentation in wiki before merge label Jun 2, 2022
Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see 1st comment.

README.md Outdated Show resolved Hide resolved
@TrainDoctor TrainDoctor removed the requires documentation requires documentation in wiki before merge label Jun 2, 2022
@AAGaming00 AAGaming00 requested a review from a team June 2, 2022 21:49
@TrainDoctor TrainDoctor force-pushed the contrib-install branch 3 times, most recently from b3619a3 to 11406de Compare June 2, 2022 21:57
@AAGaming00 AAGaming00 merged commit cadb687 into SteamDeckHomebrew:react-frontend-plugins Jun 2, 2022
KP2048 pushed a commit to EmuDeck/decky-loader that referenced this pull request May 4, 2023
* Add contributor install script

* Switched to non-tmp directory

* Fixed potential issue with passwords being not being parsed properly

* Replace up hardcoded ports and silence npm

* Removed legacy support version, changed to https git clones

* Add non-deck compatible version of script

* Switch to arguments parsed while running script for contrib pc

* Now compatible with curl install from terminal, but it's a bit fragile

* Incorrect install directory for plugintemplate

* Functionalized a ton of stuff

* Changed in anticipation of merge to react-frontend-plugins branch

* Added guide to enable Steam Deck UI and clarification about Windows

* Moved contribution scripts to contrib and provided "how to run"

* Reordered README for clarity and better placement for contribution sect.

* Looks better

* Removed un-needed file-transfers and added better checks and run info

* Improved how to run given at end of script.

* Improved warning, improved ssh invocation globally and how-to-use/run

* Link to new plugin template and added link to the wiki in readme

* testing for remote invocation

* Fixed bug with invocation via curl

* Just in case...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants