FederAPI: Support for more additions and features (Custom tarots, blinds, vouchers, etc.) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itayfeder
commented
Mar 23, 2024
itayfeder
commented
- Added voucher, blind, tarot, and sound support
- Fixed jokers not loader certain traits (like effect, blueprint_compat and eternal_compat).
- Added the ability to create custom deck backgrounds,
- Fixed jokers not loader certain traits (like effect, blueprint_compat and eternal_compat). - Added the ability to create custom deck backgrounds,
jubnl
reviewed
Mar 28, 2024
| @@ -73,6 +72,9 @@ function SMODS.injectJokers() | |||
| effect = joker.effect, | |||
| cost = joker.cost, | |||
| cost_mult = 1.0, | |||
| blueprint_compat = joker.blueprint_compat, | |||
| eternal_compat = joker.eternal_compat, | |||
| effect = joker.effect | |||
There was a problem hiding this comment.
The line 77 does not seems necessary seems the joker effect is already extracted at line 72.
The line 77 also crash the game becase there's a missing comma at the end of the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.