리뷰 이미지 조회 로직 수정 #193
Merged
리뷰 이미지 조회 로직 수정 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 리뷰 이미지 조회 로직 수정 - plannerid로 조회 -> review ids로 조회 - lazy loading 하지 않도록 미리 fetch join 하도록 수정
1jeongg
requested changes
Nov 11, 2023
| @@ -71,17 +71,21 @@ public void addReview(User user, Long chatId, ReviewRequest.AddDTO request) { | |||
| public ReviewResponse.FindAllByPlannerDTO findReviewsByPlanner(int page, Long plannerId) { | |||
| Pageable pageable = PageRequest.of(page, PAGE_SIZE); | |||
| Page<Review> pageContent = reviewJPARepository.findAllByMatchPlannerId(plannerId, pageable); | |||
| System.out.println("1번!"); | |||
| @@ -10,15 +10,12 @@ | |||
| public interface ReviewImageItemJPARepository extends JpaRepository<ReviewImageItem, Long> { | |||
|
|
|||
| @Modifying | |||
| @Query("delete from ReviewImageItem r where r.review.id = :reviewId") | |||
| @Query("delete from ReviewImageItem i where i.review.id = :reviewId") | |||
There was a problem hiding this comment.
이 부분 다른 코드랑 일관성이 안 맞는 것 같아요 r로 변경 부탁드립니다!
| SET REFERENTIAL_INTEGRITY FALSE; |
1jeongg
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
한 일