Feature: array option
#22
Conversation
maranomynet
force-pushed
the
feature/array_option
branch
from
95444ae
to
796f01d
Compare
This adds flexibility and reduces overhead for the large majority of translations where no replacements are performed.
maranomynet
force-pushed
the
feature/array_option
branch
from
796f01d
to
3830152
Compare
|
Prelminary benchmarking on Google Chrome (locally) suggests that simply switching from Array#concat to Array#slice does indeed speed things up quite a bit. (I'm not sure how that rhymes with this performance discusssion but But, regardless, this does not give the ~10x speed boost I'm looking for. :-( |
|
Switching from Array#slice to starting with a new array and filling it in the loop (i.e. |
By approximately... * 8x for `t(key, repl)` * 3x for `t.arr(key, repl)`
| function assemble (parts, replacements, count, debug) { | ||
| var result = [].concat(parts) | ||
| function assemble (parts, replacements, count, debug, array) { | ||
| var result = array ? [parts[0]] : parts[0] |
There was a problem hiding this comment.
name is odd... maybe asArray
There was a problem hiding this comment.
sure.
what about the options property-name? suggestions about that?
This seems to dent performance by 50% on Chrome, but boosts performance by 450% on Firefox.
|
Please reveiew these changes and merge them if they look good to you. I don't plan to do any more changes for now. |
|
will look to it tomorrow |
|
merged and released under 0.4.1 maybe we should do an 1.0 any time soon |
(Adds to #21)
Add
arrayoption and move "joinResult" check intoassembleThis adds a bit more flexibility and reduces overhead for the large majority of translations where no replacements are performed.
Removing the
.bind()overhead from the default function probably doesn't hurt either.