Allow replacements of placeholders for non-existing keys #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, this would allow for a use case that wasn't originally anticipated – i.e. treating the translation keys themselves as the main/default translation. I see no harm in allowing this use case. I can't see any possibility of this breaking any reasonable existing code. @StephanHoyer what about you? @evrenesat, before we merge, would you mind updating the commit to place the |
|
...and this has zero impact on performance. |
|
@maranomynet fixed the formatting. |
|
Published as v0.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an "else" statement to allow replacement of placeholders even when the key not found in the message object. We do not want to prepare messages object for base language, so I need to make placeholder replacement also work for missing keys.