Tests: Write Unit Tests for Project

.editorconfig

@@ -148,7 +148,7 @@ csharp_indent_labels = one_less_than_current
 csharp_indent_switch_labels = true
 
 # Space preferences
-csharp_space_after_cast = false
+csharp_space_after_cast = true
 csharp_space_after_colon_in_inheritance_clause = true
 csharp_space_after_comma = true
 csharp_space_after_dot = false

src/OnspringCLI/Commands/Attachments/Delete/BulkCommand.cs

@@ -114,19 +114,9 @@ public async Task<int> InvokeAsync(InvocationContext context)
 
       _logger.Information("Deleting files.");
 
-      var erroredRequests = new List<OnspringFileRequest>();
-
-      foreach (var fileRequest in fileRequests)
-      {
-        var isDeleted = await _processor.TryDeleteFile(
-          fileRequest
-        );
-
-        if (isDeleted is false)
-        {
-          erroredRequests.Add(fileRequest);
-        }
-      }
+      var erroredRequests = await _processor.TryDeleteFiles(
+        fileRequests
+      );
 
       if (erroredRequests.Any() is true)
       {

src/OnspringCLI/Commands/Attachments/Download/BulkCommand.cs

@@ -127,62 +127,26 @@ public async Task<int> InvokeAsync(InvocationContext context)
 
       _logger.Information("Downloading files.");
 
-      var outputDirectory = Path.Combine(
-        AppDomain.CurrentDomain.BaseDirectory,
+      var erroredRequests = await _processor.TryDownloadFiles(
+        fileRequests,
         OutputDirectory
       );
 
-      Directory.CreateDirectory(outputDirectory);
-
-      var fileName = Path.Combine(
-        outputDirectory,
-        "file-list.csv"
-      );
-
-      using var writer = new StreamWriter(fileName);
-      using var csv = new CsvWriter(writer, CultureInfo.InvariantCulture);
-      csv.Context.RegisterClassMap<OnspringFileResultMap>();
-
-      csv.WriteHeader<OnspringFileResult>();
-      csv.NextRecord();
-
-      var erroredRequests = new List<OnspringFileRequest>();
-
-      foreach (var fileRequest in fileRequests)
-      {
-        var file = await _processor.GetFile(
-          fileRequest,
-          OutputDirectory
-        );
-
-        if (file is null)
-        {
-          erroredRequests.Add(fileRequest);
-          continue;
-        }
-
-        var isSaved = await _processor.TrySaveFile(file);
-
-        if (isSaved is false)
-        {
-          erroredRequests.Add(fileRequest);
-          continue;
-        }
-
-        csv.WriteRecord(file);
-        csv.NextRecord();
-      }
-
       if (erroredRequests.Any() is true)
       {
         _processor.WriteFileRequestErrorReport(
           erroredRequests,
           OutputDirectory
         );
 
+        var outputDirectoryPath = Path.Combine(
+          AppDomain.CurrentDomain.BaseDirectory,
+          OutputDirectory
+        );
+
         _logger.Warning(
           "Some files were not deleted. You can find a list of the files that were not deleted in the output directory: {OutputDirectory}",
-          outputDirectory
+          outputDirectoryPath
         );
       }
 

src/OnspringCLI/Commands/Attachments/ReportCommand.cs

@@ -136,7 +136,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
       return 0;
     }
 
-    internal List<int> GetFilesFilterList()
+    private List<int> GetFilesFilterList()
     {
       var filesFilterList = new List<int>();
 
@@ -148,8 +148,15 @@ internal List<int> GetFilesFilterList()
       }
 
       using var reader = new StreamReader(FilesFilterCsv.FullName);
-      using var csv = new CsvReader(reader, CultureInfo.InvariantCulture);
+
+      var config = new CsvConfiguration(CultureInfo.InvariantCulture)
+      {
+        HasHeaderRecord = false,
+      };
+
+      using var csv = new CsvReader(reader, config);
       var files = csv.GetRecords<int>().ToList();
+
       filesFilterList.AddRange(files);
 
       return filesFilterList;

src/OnspringCLI/Commands/Attachments/TransferCommand.cs

@@ -134,13 +134,9 @@ public async Task<int> InvokeAsync(InvocationContext context)
 
       _logger.Information("Begin transferring attachments.");
 
-      await Parallel.ForEachAsync(
-        sourceRecords,
-        async (record, token) =>
-          await _processor.TransferAttachments(
-            AttachmentTransferSettings,
-            record
-          )
+      await _processor.TransferAttachments(
+        AttachmentTransferSettings,
+        sourceRecords
       );
 
       _logger.Information("Attachments transferred.");

src/OnspringCLI/Extensions/ArgumentResultExtensions.cs

@@ -1,5 +1,6 @@
 namespace OnspringCLI.Extensions;
 
+[ExcludeFromCodeCoverage]
 public static class ArgumentResultExtensions
 {
   public static List<int> ParseToIntegerList(this ArgumentResult result)

src/OnspringCLI/Extensions/CommandLineBuilderExtensions.cs

@@ -1,8 +1,29 @@
 namespace OnspringCLI.Extensions;
 
+[ExcludeFromCodeCoverage]
 public static class CommandLineBuilderExtensions
 {
-  public static CommandLineBuilder AddHelpFigletText(this CommandLineBuilder builder)
+  public static CommandLineBuilder AddHost(
+    this CommandLineBuilder builder,
+    string[] args
+  )
+  {
+    return builder
+    .UseHost(
+      _ =>
+        Host.CreateDefaultBuilder(args),
+        host =>
+          host
+          .AddServices()
+          .AddSerilog()
+          .AddCommandHandlers()
+    );
+  }
+
+  public static CommandLineBuilder AddFiglet(
+    this CommandLineBuilder builder,
+    string text
+  )
   {
     return builder
     .UseHelp(
@@ -15,7 +36,7 @@ public static CommandLineBuilder AddHelpFigletText(this CommandLineBuilder build
             .Prepend(
               _ =>
                 AnsiConsole.Write(
-                  new FigletText("OnspringCLI")
+                  new FigletText(text)
                   .Color(Color.Orange3)
                 )
             )

src/OnspringCLI/Extensions/HostBuilderExtensions.cs

@@ -1,5 +1,6 @@
 namespace OnspringCLI.Extensions;
 
+[ExcludeFromCodeCoverage]
 static class HostBuilderExtensions
 {
   public static IHostBuilder AddSerilog(this IHostBuilder hostBuilder)
@@ -21,17 +22,25 @@ public static IHostBuilder AddSerilog(this IHostBuilder hostBuilder)
           new OnspringFileRequestDestructuringPolicy(),
           new OnspringSaveFileRequestDestructuringPolicy()
         )
-        .MinimumLevel.Verbose()
         .MinimumLevel.Override("Microsoft", LogEventLevel.Fatal)
         .Enrich.FromLogContext()
-        .WriteTo.File(
-          new CompactJsonFormatter(),
-          logFilePath,
-          options.LogLevel
+        .WriteTo.Logger(
+          lc =>
+            lc
+            .MinimumLevel.Verbose()
+            .WriteTo.File(
+              new CompactJsonFormatter(),
+              logFilePath,
+              options.LogLevel
+            )
         )
-        .WriteTo.Console(
-          restrictedToMinimumLevel: logLevelSwitch.MinimumLevel,
-          theme: AnsiConsoleTheme.Code
+        .WriteTo.Logger(
+          lc =>
+            lc
+            .MinimumLevel.ControlledBy(logLevelSwitch)
+            .WriteTo.Console(
+              theme: AnsiConsoleTheme.Code
+            )
         );
       }
     );

src/OnspringCLI/Extensions/RootCommandExtensions.cs

@@ -1,8 +1,9 @@
 namespace OnspringCLI.Extensions;
 
+[ExcludeFromCodeCoverage]
 static class RootCommandExtensions
 {
-  public static CommandLineBuilder Create(this RootCommand root)
+  public static CommandLineBuilder CreateBuilder(this RootCommand root)
   {
     return new CommandLineBuilder(root);
   }

src/OnspringCLI/Interfaces/IAttachmentsProcessor.cs

@@ -18,15 +18,13 @@ Task<List<OnspringFileInfoResult>> GetFileInfos(
     List<OnspringFileRequest> fileRequests
   );
 
-  Task<OnspringFileResult?> GetFile(
-    OnspringFileRequest fileRequest,
+  Task<List<OnspringFileRequest>> TryDownloadFiles(
+    List<OnspringFileRequest> fileRequests,
     string outputDirectory
   );
 
-  Task<bool> TrySaveFile(OnspringFileResult file);
-
-  Task<bool> TryDeleteFile(
-    OnspringFileRequest fileRequest
+  Task<List<OnspringFileRequest>> TryDeleteFiles(
+    List<OnspringFileRequest> fileRequest
   );
 
   Task<List<int>> GetRecordIdsFromReport(int reportId);
@@ -45,6 +43,11 @@ Task<List<ResultRecord>> GetSourceRecordsToProcess(
   );
 
   Task TransferAttachments(
+    IAttachmentTransferSettings settings,
+    List<ResultRecord> sourceRecord
+  );
+
+  Task TransferRecordAttachments(
     IAttachmentTransferSettings settings,
     ResultRecord sourceRecord
   );

src/OnspringCLI/Interfaces/IProgressBarFactory.cs

@@ -3,4 +3,4 @@ namespace OnspringCLI.Factories;
 public interface IProgressBarFactory
 {
   IProgressBar Create(int maxTicks, string initialMessage);
-}
+}

src/OnspringCLI/Logging/OnspringFileRequestDestructuringPolicy.cs

@@ -1,5 +1,6 @@
 namespace OnspringCLI.Logging;
 
+[ExcludeFromCodeCoverage]
 public class OnspringFileRequestDestructuringPolicy : IDestructuringPolicy
 {
   public bool TryDestructure(

src/OnspringCLI/Logging/OnspringSaveFileRequestDestructuringPolicy.cs

@@ -1,5 +1,6 @@
 namespace OnspringCLI.Logging;
 
+[ExcludeFromCodeCoverage]
 public class OnspringSaveFileRequestDestructuringPolicy : IDestructuringPolicy
 {
   public bool TryDestructure(

src/OnspringCLI/Maps/OnspringFileInfoResultMap.cs

@@ -1,5 +1,6 @@
 namespace OnspringCLI.Maps;
 
+[ExcludeFromCodeCoverage]
 public class OnspringFileInfoResultMap : ClassMap<OnspringFileInfoResult>
 {
   public OnspringFileInfoResultMap()

src/OnspringCLI/Maps/OnspringFileRequestMap.cs

@@ -1,5 +1,6 @@
 namespace OnspringCLI.Maps;
 
+[ExcludeFromCodeCoverage]
 public class OnspringFileRequestMap : ClassMap<OnspringFileRequest>
 {
   public OnspringFileRequestMap()

src/OnspringCLI/Maps/OnspringFileResultMap.cs

@@ -1,5 +1,6 @@
 namespace OnspringCLI.Maps;
 
+[ExcludeFromCodeCoverage]
 public class OnspringFileResultMap : ClassMap<OnspringFileResult>
 {
   public OnspringFileResultMap()

src/OnspringCLI/Models/OnspringFile.cs

@@ -8,6 +8,10 @@ public class OnspringFile
   public int FileId { get; set; }
   public string? FileName { get; set; }
 
+  public OnspringFile()
+  {
+  }
+
   public OnspringFile(
     int recordId,
     int fieldId,

src/OnspringCLI/Models/OnspringFileInfoResult.cs

@@ -10,6 +10,10 @@ public class OnspringFileInfoResult : OnspringFile
   public decimal FileSizeInGB => Math.Round(FileSizeInBytes / 1000000000, 4);
   public decimal FileSizeInGiB => Math.Round(FileSizeInBytes / 1073741824, 4);
 
+  public OnspringFileInfoResult()
+  {
+  }
+
   public OnspringFileInfoResult(
     int recordId,
     int fieldId,

src/OnspringCLI/Models/OnspringFileRequest.cs

@@ -7,6 +7,8 @@ public class OnspringFileRequest
   public int FileId { get; set; }
   public string FieldName { get; set; } = string.Empty;
 
+  public OnspringFileRequest() { }
+
   public OnspringFileRequest(
     int recordId,
     int fieldId,

src/OnspringCLI/OnspringCLI.csproj

@@ -34,11 +34,11 @@
 
   <ItemGroup>
     <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
-      <_Parameter1>OnspringCLITests</_Parameter1>
+      <_Parameter1>OnspringCLI.Tests</_Parameter1>
     </AssemblyAttribute>
   </ItemGroup>
 
-  <ItemGroup>
+  <ItemGroup Condition=" '$(Configuration)' == 'Debug' ">
     <None Update="settings\**\*.*">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>