Fixed issue where ranged floating point values could stop responding …

…to updates
SteveBarnegren · May 9, 2022 · 567599c · 567599c
1 parent a06aa5c
commit 567599c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/MirrorUI/MirrorUI/Types/NumericEntryBinder.swift b/MirrorUI/MirrorUI/Types/NumericEntryBinder.swift
@@ -14,12 +14,13 @@ class NumericEntryBinder {
     let textBinding: Binding<String>
 
     private let _commit: () -> Void
+    private let _clear: () -> Void
 
     convenience init<T>(state: Ref<[String: Any]>, ref: PropertyRef<T>) where T: StringRepresentable {
 
         self.init(state: state,
                   get: { ref.value },
-                  set: {  ref.value = $0 },
+                  set: { ref.value = $0 },
                   stateKey: "text")
     }
 
@@ -49,11 +50,19 @@ class NumericEntryBinder {
             editText = nil
         }
 
+        _clear = {
+            editText = nil
+        }
+
         textBinding = Binding(get: { editText ?? "" },
                               set: { editText = $0 })
     }
 
     func commit() {
         _commit()
     }
+
+    func clear() {
+        _clear()
+    }
 }
diff --git a/MirrorUI/MirrorUI/View Mapping/ViewMapping+BinaryFloatingPoint.swift b/MirrorUI/MirrorUI/View Mapping/ViewMapping+BinaryFloatingPoint.swift
@@ -87,7 +87,7 @@ fileprivate func makeRangedFloatingPointView<T: BinaryFloatingPoint>(context: Vi
     let stack = VStack(alignment: .leading) {
         Text(context.propertyName)
         HStack {
-            Slider(value: numericBinding, in: range)
+            Slider(value: numericBinding, in: range, onEditingChanged: { _ in textBinder.clear() })
             Button() {
                 editing = !editing
             } label: {