Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Refactor ByteBuf release method in module pulsar-broker #4

Closed
wants to merge 1 commit into from

Conversation

StevenLuMT
Copy link
Owner

@StevenLuMT StevenLuMT commented Jan 30, 2023

Motivation

It may throw an exception when release a ByteBuf object. so the exception in ByteBuf.release should be checked.

Modifications

Use ReferenceCountUtil.safeRelease() instead of ByteBuf.release() in all Pulsar's classes.

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: #4

@StevenLuMT StevenLuMT changed the title Refactor ByteBuf release method in module pulsar-broker [fix][broker] Refactor ByteBuf release method in module pulsar-broker Jan 30, 2023
@StevenLuMT StevenLuMT closed this Jan 30, 2023
@StevenLuMT StevenLuMT reopened this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant